Date: Mon, 14 Oct 2002 23:56:10 -0400 From: Bosko Milekic <bmilekic@unixdaemons.com> To: John Baldwin <jhb@FreeBSD.org> Cc: net@FreeBSD.org Subject: Re: Rename of MSIZE kernel option.. Message-ID: <20021014235610.A59973@unixdaemons.com> In-Reply-To: <XFMail.20021014161512.jhb@FreeBSD.org>; from jhb@FreeBSD.org on Mon, Oct 14, 2002 at 04:15:12PM -0400 References: <XFMail.20021014161512.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Not that my opinion really holds much weight with you guys but for what it's worth, I think the change would be gratuitist. 1. MSIZE has been around forever. 2. The argument that sys/sys/mbuf.h should have MSIZE removed/changed because some other code may use it is fallacious. The "other code" should be careful not to use a constant that has been so named for the longest time I can recall. On Mon, Oct 14, 2002 at 04:15:12PM -0400, John Baldwin wrote: > Would people be open to renaming the 'MSIZE' kernel option to something > more specific such as 'MBUF_SIZE' or 'MBUFSIZE'? Using 'MSIZE' can > break other places in the kernel. For example, ISA device ivars have > an ivar for the size of a memory resource called 'MSIZE' and the kernel > option causes breakage in src/sys/isa/isavar.h: > > ISA_ACCESSOR(msize, MSIZE, int) > > when ISA_ACCESSOR is properly defined via __BUS_ACCESSOR() rather than > homerolling a private copy of __BUS_ACCESSOR(). For now I've fixed it > to rename the ISA ivar to ISA_IVAR_MEMSIZE but MSIZE seems to be too > generic a name for a kernel option and it would be nice to avoid this > problem in the future. > > -- > > John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ > "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ -- Bosko Milekic * bmilekic@unixdaemons.com * bmilekic@FreeBSD.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021014235610.A59973>