Date: Tue, 12 Dec 2000 13:09:41 -0800 (PST) From: John Baldwin <jhb@FreeBSD.org> To: Matthew Jacob <mjacob@feral.com> Cc: Peter Jeremy <peter.jeremy@alcatel.com.au>, cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, Poul-Henning Kamp <phk@FreeBSD.org> Subject: Re: cvs commit: src/sys/sys kernel.h eventhandler.h src/sys/kern Message-ID: <XFMail.001212130941.jhb@FreeBSD.org> In-Reply-To: <Pine.LNX.4.21.0012121307010.26829-100000@zeppo.feral.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 12-Dec-00 Matthew Jacob wrote: > >> On 12-Dec-00 Matthew Jacob wrote: >> > >> >> I wasn't sure if this breakage had been seen by anyone else. The fix is >> >> to >> >> have agp include sys/proc.h. I'll commit in a second.. >> > >> > I believe the issue here is that poul *removed* sys/proc.h (from this and >> > tty_cons.c). >> >> It was hidden because sys/mutex.h includes sys/proc.h, and >> sys/eventhandler.h >> used to include sys/mutex.h. Blech. > > Well, what's the right answer. Aside from the annoyance of breakage from a > well intentioned change by Poul, what's the *desired* goal here wrt include > files if you want to reference curproc? You use <sys/proc.h>. However, due to the nested include ugliness, Poul's script found that sys/proc.h was unneeded. > -matt -- John Baldwin <jhb@FreeBSD.org> -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.Baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.001212130941.jhb>