Date: Mon, 19 Jan 2004 19:51:29 +0100 From: Mathieu Arnold <mat@FreeBSD.org> To: obrien@FreeBSD.org Cc: ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/mail/p5-Mail-SpamAssassin Makefile distinfo pkg-plist Message-ID: <2549890.1074541889@pouet.in.mat.cc> In-Reply-To: <20040119184544.GB6433@dragon.nuxi.com> References: <200401191544.i0JFib85052132@repoman.freebsd.org> <20040119163258.GB4722@dragon.nuxi.com> <359167705.1074533881@andromede.reaumur.absolight.net> <20040119184544.GB6433@dragon.nuxi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
+-Le 19/01/2004 10:45 -0800, David O'Brien =E9crivait :
| On Mon, Jan 19, 2004 at 05:38:01PM +0100, Mathieu Arnold wrote:
|> +-le 19/01/2004 08:32 -0800, David O'Brien ?crivait :
|> | On Mon, Jan 19, 2004 at 07:44:37AM -0800, Mathieu Arnold wrote:
|> |> mat 2004/01/19 07:44:37 PST
|> |>=20
|> |> FreeBSD ports repository
|> |>=20
|> |> Modified files:
|> |> mail/p5-Mail-SpamAssassin Makefile distinfo pkg-plist=20
|> |> Log:
|> |> Update to 2.62
|> |> Have the least thing possible between bsd.port.pre.mk and post.mk
|> |=20
|> | Please back this out. It is hard to read and find the dependencies.
|> | The Porter's handbook clearly documents where w/in a port's Makefile
|> | {BUILD,RUN}_DEPENDS belong in the Makefile.
|>=20
|> Do you really mean that every perl port that does this should be changed
|> ? it's the first time someone tells me so.
|=20
| Well, I guess that opens up a discussion then. I don't use many "p5"
| ports, but I certainly do use SpamAssassin daily. So I hadn't noticed
| that they go against the Porters Handbook and 'portlint'. It is
| important to keep things all in the proper section so a user like me can
| know what dependencies there are. Often I install dependencies from a
| precompiled package before I add local patches to the "leaf" port that I
| ultimately want installed.
Well, portlint will complain if you do things badly, but it won't complain
when you do just that.
perl ports have been done this way for ages, I mean, the normal
dependencies at the right place, and the dependencies depending on perl
version at the end. I was told it was the right way to do it when I began
updating ports, so I though it was the right way.
--=20
Mathieu Arnold
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2549890.1074541889>