Date: Tue, 22 Sep 2020 22:54:23 +0200 From: Mateusz Guzik <mjguzik@gmail.com> To: Alan Somers <asomers@freebsd.org> Cc: Kyle Evans <kevans@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r365643 - head/bin/cp Message-ID: <CAGudoHEoF3T=hD7-tSNzz0--xKB3LwbjZQH1Xtxujq19hdm2vg@mail.gmail.com> In-Reply-To: <CAOtMX2gtCmyRrhUVia6Arc_PCbgoasG61Xwt=cUaDd1Q1Gtw8g@mail.gmail.com> References: <202009112049.08BKnavL032212@repo.freebsd.org> <CACNAnaGXCt=PezNX-5KU7xTk%2By-um37p8sk1c1KUEc4ywDQ5uQ@mail.gmail.com> <CAOtMX2gtCmyRrhUVia6Arc_PCbgoasG61Xwt=cUaDd1Q1Gtw8g@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Can we instead add a workaround to the build tree? Where is cp /dev/null coming from anyway? Perhaps this can be patched to touch the target file. On 9/22/20, Alan Somers <asomers@freebsd.org> wrote: > On Tue, Sep 22, 2020 at 2:48 PM Kyle Evans <kevans@freebsd.org> wrote: > >> On Fri, Sep 11, 2020 at 3:49 PM Alan Somers <asomers@freebsd.org> wrote: >> > >> > Author: asomers >> > Date: Fri Sep 11 20:49:36 2020 >> > New Revision: 365643 >> > URL: https://svnweb.freebsd.org/changeset/base/365643 >> > >> > Log: >> > cp: fall back to read/write if copy_file_range fails >> > >> > Even though copy_file_range has a file-system agnostic version, it >> still >> > fails on devfs (perhaps because the file descriptor is non-seekable?) >> In >> > that case, fallback to old-fashioned read/write. Fixes >> > "cp /dev/null /tmp/null" >> > >> >> Hi, >> >> Any objection to adding a quick UPDATING entry for this? I'm seeing >> occasional reports of this breakage as recent as today on IRC from >> folks that were a little bit thrown off by this because it throws up >> fairly far into the build and looks like a stand build regression >> instead of a cp regression. >> >> Thanks, >> >> Kyle Evans >> > > No objection. Can you suggest the proper wording? > _______________________________________________ > svn-src-all@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/svn-src-all > To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" > -- Mateusz Guzik <mjguzik gmail.com>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGudoHEoF3T=hD7-tSNzz0--xKB3LwbjZQH1Xtxujq19hdm2vg>