Date: Mon, 10 Oct 2005 12:17:54 +0200 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Poul-Henning Kamp <phk@phk.freebsd.dk> Cc: Peter Edwards <peadar@FreeBSD.org>, cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, S?ren Schmidt <sos@FreeBSD.org> Subject: Re: cvs commit: src/sys/dev/ata atapi-cd.c Message-ID: <20051010101754.GC3975@garage.freebsd.pl> In-Reply-To: <13707.1128939139@critter.freebsd.dk> References: <20051010101013.GB3975@garage.freebsd.pl> <13707.1128939139@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
--yLVHuoLXiP9kZBkt Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 10, 2005 at 12:12:19PM +0200, Poul-Henning Kamp wrote: +> In message <20051010101013.GB3975@garage.freebsd.pl>, Pawel Jakub Dawide= k write +> s: +> > +> >On Mon, Oct 10, 2005 at 11:06:49AM +0200, S?ren Schmidt wrote: +> >+> On 09/10/2005, at 23:11, Peter Edwards wrote: +> >+>=20 +> >+> Why did you ask me to review this when you just committed it anyway ? +> >+>=20 +> >+> As I said I'm not sure this is the right way to fix this.. +> > +> >It seems to be right. I do it in my GEOM classes to handle g_clone_bio() +> >failures better. So the only objection I may have is that it could be +> >done a bit cleaner: +>=20 +> Please see geom_disk.c So bascially, you allocate next bio before sending current one? That's one way of doing it, but I prefer to treat bio allocation as atomic operation, ie. if I cannot allocate all bios, I send no bio down and call g_io_deliver(parent_bio, ENOMEM) right away. Do you see any protential problems with doing so? --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --yLVHuoLXiP9kZBkt Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (FreeBSD) iD8DBQFDSj/SForvXbEpPzQRAsCvAJ0TsTKLVhT2f1Xuq2WXAP7k6zeUlwCdEe2y 4Gu+dxjzEWODT491ddMgpLk= =iKo5 -----END PGP SIGNATURE----- --yLVHuoLXiP9kZBkt--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051010101754.GC3975>