Date: Tue, 17 Nov 2020 17:32:21 +0000 From: Jessica Clarke <jrtc27@freebsd.org> To: Adrian Chadd <adrian@FreeBSD.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r367771 - head/sbin/nvmecontrol Message-ID: <5883B567-0E7D-475A-B04B-25774FB22A6C@freebsd.org> In-Reply-To: <5C44DBA6-CBA2-49E9-8AFC-45C62664D2FD@freebsd.org> References: <202011171712.0AHHCS3V017391@repo.freebsd.org> <5C44DBA6-CBA2-49E9-8AFC-45C62664D2FD@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 17 Nov 2020, at 17:29, Jessica Clarke <jrtc27@freebsd.org> wrote:
> On 17 Nov 2020, at 17:12, Adrian Chadd <adrian@FreeBSD.org> wrote:
>> @@ -175,8 +176,7 @@ update_firmware(int fd, uint8_t *payload, int32_t payl
>> errx(EX_OSERR, "unable to malloc %zd bytes", (size_t)max_xfer_size);
>>
>> while (resid > 0) {
>> - size = (resid >= (int32_t)max_xfer_size) ?
>> - max_xfer_size : resid;
>> + size = (resid >= max_xfer_size) ? max_xfer_size : resid;
>
> MIN from the already-included sys/param.h?
>
> (Otherwise: you have an extra space after ?)
Also why is off signed when it counts up from 0?
Jess
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5883B567-0E7D-475A-B04B-25774FB22A6C>