Date: Wed, 21 Feb 2001 21:25:49 +0100 From: Poul-Henning Kamp <phk@critter.freebsd.dk> To: Ben Smithurst <csxbcs@comp.leeds.ac.uk> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/share/man/man9 style.9 Message-ID: <3555.982787149@critter> In-Reply-To: Your message of "Wed, 21 Feb 2001 20:16:16 GMT." <20010221201615.A25231@comp.leeds.ac.uk>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <20010221201615.A25231@comp.leeds.ac.uk>, Ben Smithurst writes: >Poul-Henning Kamp wrote: > >> Better, and more readable: >> >> error = function(a1, a2); >> if (error != 0) > >Well that's a matter of opinion, but I suppose it's easily changed. :-) >I figured there's enough use of 'if ((var = func()) != 0)' in FreeBSD >that everyone knows exactly what it does and yours isn't really any more >readable. But it can easily be changed if people generally agree with >you. The above form is generally more grep(1) and sed(1)'able -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3555.982787149>