Date: Fri, 6 Apr 2001 23:39:59 +1000 (EST) From: Bruce Evans <bde@zeta.org.au> To: Peter Pentchev <roam@orbitel.bg> Cc: freebsd-bugs@FreeBSD.ORG Subject: Re: kern/26317: /modules not created by make installkernel Message-ID: <Pine.BSF.4.21.0104062333540.56456-100000@besplex.bde.org> In-Reply-To: <20010406145604.A447@ringworld.oblivion.bg>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 6 Apr 2001, Peter Pentchev wrote:
> On Wed, Apr 04, 2001 at 04:13:25PM +1000, Bruce Evans wrote:
> > On Tue, 3 Apr 2001, Peter Pentchev wrote:
> > > I wonder, though, whether the 'installkernel' target in Makefile.inc1 should
> > > not, too, invoke a 'make hierarchy', or at least some subset of that, to do
> > > an mtree from BSD.root.dist; that should ensure that the /modules directory
> > > is there.
> >
> > No more than sh/Makefile should invoke a 'make hierarchy', or at least some
> > subset of that, to recover from /bin somehow not existing.
>
> So, basically, are you saying that this is not a problem and this PR should
> be closed, or do you think the installkernel target should at least make
> an attempt at doing the right thing in case of a user mess-up, and just
> mkdir ${DESTDIR}/modules?
I would close it.
Using mkdir would be wrong since it might get the directory ownership or
permissions wrong.
Bruce
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0104062333540.56456-100000>