Date: Tue, 23 Jan 2007 01:28:23 -0700 (MST) From: "M. Warner Losh" <imp@bsdimp.com> To: nate@root.org Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/cam/scsi scsi_da.c Message-ID: <20070123.012823.1341031192.imp@bsdimp.com> In-Reply-To: <45B5AE3B.6010005@root.org> References: <20070122043408.4171816A492@hub.freebsd.org> <45B5AE3B.6010005@root.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <45B5AE3B.6010005@root.org>
Nate Lawson <nate@root.org> writes:
: Warner Losh wrote:
: > imp 2007-01-22 04:34:03 UTC
: >
: > FreeBSD src repository
: >
: > Modified files:
: > sys/cam/scsi scsi_da.c
: > Log:
: > Add quirk for EasyMP3 EM732X usb 2.0 flash mp3 player.
: > (It appears that the quirk proceedures link has disappeared and that
: > this PR complied with it, if there's a problem, please contact me).
: >
: > PR: usb/96546
: >
: > Revision Changes Path
: > 1.201 +8 -0 src/sys/cam/scsi/scsi_da.c
: >
: >
: > Index: src/sys/cam/scsi/scsi_da.c
: > diff -u src/sys/cam/scsi/scsi_da.c:1.200 src/sys/cam/scsi/scsi_da.c:1.201
: > --- src/sys/cam/scsi/scsi_da.c:1.200 Tue Dec 5 07:45:28 2006
: > +++ src/sys/cam/scsi/scsi_da.c Mon Jan 22 04:34:03 2007
: > @@ -466,6 +466,14 @@
: > {T_DIRECT, SIP_MEDIA_REMOVABLE, "X-Micro", "Flash Disk",
: > "*"}, /*quirks*/ DA_Q_NO_SYNC_CACHE
: > },
: > + {
: > + /*
: > + * EasyMP3 EM732X USB 2.0 Flash MP3 Player
: > + * PR: usb/96546
: > + */
: > + {T_DIRECT, SIP_MEDIA_REMOVABLE, "*", "MP3 Player*",
: > + "1.0"}, /*quirks*/ DA_Q_NO_SYNC_CACHE
: > + },
: > };
: >
: > static disk_strategy_t dastrategy;
:
: Um, this matches every device that has "MP3 Player" somewhere in it.
: Are you sure it doesn't have a vendor string?
See the PR for details and suggest something better.
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070123.012823.1341031192.imp>