Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 29 Apr 2020 18:20:30 +0300
From:      Konstantin Belousov <kostikbel@gmail.com>
To:        Michal Meloun <mmel@freebsd.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r360463 - head/libexec/rtld-elf
Message-ID:  <20200429152030.GB2522@kib.kiev.ua>
In-Reply-To: <202004291406.03TE6g1c031338@repo.freebsd.org>
References:  <202004291406.03TE6g1c031338@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Apr 29, 2020 at 02:06:42PM +0000, Michal Meloun wrote:
> Author: mmel
> Date: Wed Apr 29 14:06:42 2020
> New Revision: 360463
> URL: https://svnweb.freebsd.org/changeset/base/360463
> 
> Log:
>   Don't allow to use FPU inside of rtld library.
>   Clang10 may use FPU instructions for optimizing operations with
>   memory blocks. But we don't want to do lengthy save/restore of all
>   FPU registers across each rtld_start() call.
>   
>   MFC after:	3 week
> 
> Modified:
>   head/libexec/rtld-elf/Makefile
> 
> Modified: head/libexec/rtld-elf/Makefile
> ==============================================================================
> --- head/libexec/rtld-elf/Makefile	Wed Apr 29 13:45:21 2020	(r360462)
> +++ head/libexec/rtld-elf/Makefile	Wed Apr 29 14:06:42 2020	(r360463)
> @@ -48,6 +48,9 @@ MLINKS?=	rtld.1 ld-elf.so.1.1 \
>  		rtld.1 ld.so.1
>  
>  CFLAGS+=	-fpic -DPIC $(DEBUG)
> +CFLAGS.armv6+=	-mfpu=none
> +CFLAGS.armv7+=	-mfpu=none
I cleaned rtld-elf/Makefile of all MD bits, please move this to
arm/Makefile.inc.

> +	
>  LDFLAGS+=	-shared -Wl,-Bsymbolic -Wl,-z,defs -nostdlib -e ${RTLD_ENTRY}
>  # Pull in the dependencies that we use from libc
>  .include "rtld-libc/Makefile.inc"



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200429152030.GB2522>