Date: Sat, 19 Oct 2013 13:49:36 -0700 From: Garrett Cooper <yaneurabeya@gmail.com> To: Julio Merino <julio@meroh.net> Cc: "freebsd-testing@freebsd.org" <freebsd-testing@freebsd.org>, Rui Paulo <rpaulo@fnop.net>, Simon Gerraty <sjg@juniper.net> Subject: Re: Populating /usr/tests Message-ID: <6DC6C1E8-7AEF-439E-9250-D223A56EF432@gmail.com> In-Reply-To: <CADyfeQU13ukMK1aMMXKof=Wigqf8hzEBOT91KGdPJcd5nQaWww@mail.gmail.com> References: <CADyfeQU13ukMK1aMMXKof=Wigqf8hzEBOT91KGdPJcd5nQaWww@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
You're missing a lot of code in etc/, some in Makefile.inc1, and other piece= s in share/mk as well with bsd.own.mk. Also, your approach with tests/Makefi= le is ok, but it doesn't partition well with prove.test.mk on my branch, etc= . Thanks, -Garrett PS No worries about the email addresses; I still use yanegomi, but mainly as= a spam catch address nowadays. > On Oct 19, 2013, at 8:49, Julio Merino <julio@meroh.net> wrote: >=20 > Hello, >=20 > [ CCing same interested parties as before ] >=20 > Here comes the next round of patches. This time the goal is to start > populating /usr/tests (which already exists) with the only test > program currently available in the tree: src/lib/libcrypt/tests/*. >=20 > With this boilerplate in place, adding new test programs to the base > system should be straightforward (which is the goal here!). I'll be > happy to provide a tutorial later if we agree to this scheme, similar > to the one we have for NetBSD (http://wiki.netbsd.org/tutorials/atf/), > detailing the procedure to add both atf-based and "old-style" test > programs. >=20 > The README file added in add-tests-hierarchy.diff and the tests.7 page > added in add-tests-7.diff might answer some of the questions you might > have. Not repasting their contents here. >=20 > As before, the new set of patches is in > http://portal.meroh.net/~jmmv/freebsd-testing/ . The series file in > it lists the order in which they need to be read/applied and each > patch has a header usable as the commit log. >=20 > I have successfully tested this both in amd64 and powerpc with update > and clean builds/installs. However, please review carefully. >=20 > Thoughts? >=20 > Thanks, >=20 > --=20 > Julio Merino / @jmmv > _______________________________________________ > freebsd-testing@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-testing > To unsubscribe, send any mail to "freebsd-testing-unsubscribe@freebsd.org"=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6DC6C1E8-7AEF-439E-9250-D223A56EF432>