Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 14 Jun 2017 08:52:05 -0700 (PDT)
From:      "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net>
To:        Alan Cox <alc@rice.edu>
Cc:        Hans Petter Selasky <hps@selasky.org>, Alan Cox <alc@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r319905 - in head/sys: kern sys
Message-ID:  <201706141552.v5EFq5rJ062076@pdx.rh.CN85.dnsmgr.net>
In-Reply-To: <d7318b86-c168-1bbb-d795-071abef07926@rice.edu>

next in thread | previous in thread | raw e-mail | index | archive | help
[ Charset UTF-8 unsupported, converting... ]
> On 06/14/2017 06:04, Hans Petter Selasky wrote:
> > On 06/13/17 19:49, Alan Cox wrote:
> >> +#define    bitcount64(x)    __bitcount64((uint64_t)(x))
> >
> > bitcount64() is already defined by sys/libkern.h - use that? 
> 
> This snippet appears in code that is only used when compiling this file
> as a user-space application for testing.  Attempting to use
> sys/libkern.h in the user-space compilation provoked warnings.

Could we please add a comment to this define indicating this?

-- 
Rod Grimes                                                 rgrimes@freebsd.org



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201706141552.v5EFq5rJ062076>