Date: Wed, 30 Jun 2004 12:31:29 -0500 (CDT) From: Mark Linimon <linimon@lonesome.com> To: Herve Quiroz <herve.quiroz@esil.univ-mrs.fr> Cc: freebsd-java@FreeBSD.org Subject: Re: java/68516: [PATCH] bsd.kava.mk: re-apply previous PR improvements Message-ID: <Pine.LNX.4.44.0406301225530.32355-100000@pancho> In-Reply-To: <200406301452.i5UEqWb7091785@arabica.esil.univ-mrs.fr>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 30 Jun 2004, Herve Quiroz wrote: > Ironically, I realized by doing this patch that the original patch from Mark > seemed to be broken regarding bsd.java.mk (a typo: "check-makevers" -> > "check-makevars"). Yep, just a typo. I vaguely remember doing some regression testing with setting up bogus user environments and trying to exercise each code path, but I must have missed that one. For those that don't understand the impact of the changes, they are designed to allow 'make index' and 'make search' to succeed despite any bogus user environment. The use of .BEGIN or .error directives in Makefiles introduces such fragility; they should only be used in cases to indicate that the ports infrastructure itself is broken (has had a bad commit to the master repository), rather than that there is some invalid setup on an individual machine. And yes, I know that we have a number of these scattered around. They all need to be fixed.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.LNX.4.44.0406301225530.32355-100000>