Date: Sun, 15 Nov 2009 13:26:13 +0100 (CET) From: Oliver Fromme <olli@fromme.com> To: rene@freebsd.org (Rene Ladan) Cc: Perforce Change Reviews <perforce@freebsd.org> Subject: Re: PERFORCE change 170633 for review Message-ID: <200911151226.nAFCQD6g005359@haluter.fromme.com> In-Reply-To: <200911142333.nAENXWrT017367@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Rene Ladan wrote: > http://p4web.freebsd.org/chv.cgi?CH=170633 > > Change 170633 by rene@rene_self on 2009/11/14 23:32:57 > > [porters handbook] > Add a section about Clang to the "Dos and Don'ts" chapter. > To be reviewed by the clang team and the doc review team. > > Affected files ... > > .. //depot/projects/docproj_nl/en_US.ISO8859-1/books/porters-handbook/book.sgml#50 edit > > Differences ... > > ==== //depot/projects/docproj_nl/en_US.ISO8859-1/books/porters-handbook/book.sgml#50 (text+ko) ==== > [...] > + <listitem> > + <para>Respect <makevar>CC</makevar> and <makevar>CXX</makevar>. Do > + not any of <filename>cc</filename>, <filename>c99</filename>, > + <filename>gcc</filename>, <filename>c++</filename>, or > + <filename>g++</filename> directly.</para> > + </listitem> The last sentence is incomplete. I think it's missing a verb like "do not _use_ any of ... directly". > + <listitem> > + <para>The main function must be properly declared as</para> > + > + <programlisting>int main(int argc, char **argv)</programlisting> > + </listitem> I think "int main(void)" is also valid if the program doesn't use any command line arguments, in conformance with the C standard. See src/usr/bin/true/true.c for example. Best regards Oliver -- Oliver Fromme, Bunsenstr. 13, 81735 Muenchen, Germany ``We are all but compressed light'' (Albert Einstein)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200911151226.nAFCQD6g005359>