Date: Wed, 08 Dec 2010 10:14:13 +0100 From: Martin Matuska <mm@FreeBSD.org> To: Pawel Jakub Dawidek <pjd@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r216291 - head/cddl/contrib/opensolaris/lib/libzfs/common Message-ID: <4CFF4C65.4030607@FreeBSD.org> In-Reply-To: <20101208090433.GB1692@garage.freebsd.pl> References: <201012080857.oB88vbH6096250@svn.freebsd.org> <20101208090433.GB1692@garage.freebsd.pl>
next in thread | previous in thread | raw e-mail | index | archive | help
Here are some arguments: a) it was removed in OpenSolaris rev. 12865:08987220809a b) a root pool does not not have to be a boot pool So if we need a warning here, it should print only some general suggestion because user may attach any vdev (e.g. a file or a memory disk) to make a mirror from a root pool. And as this was removed upstream the warning should be put into perforce as well. Dňa 08.12.2010 10:04, Pawel Jakub Dawidek wrote / napísal(a): > On Wed, Dec 08, 2010 at 08:57:37AM +0000, Martin Matuska wrote: >> Author: mm >> Date: Wed Dec 8 08:57:37 2010 >> New Revision: 216291 >> URL: http://svn.freebsd.org/changeset/base/216291 >> >> Log: >> Do not print OpenSolaris hint to use (non-existing) installgrub(1) command >> if creating a mirror by attaching a new vdev to a root pool. > This warning is helpful, just incorrect. It should be changed to show > steps that are needed on FreeBSD and not just commented out. > I left it on purpose as a reminder. >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4CFF4C65.4030607>