Date: Thu, 30 Sep 2010 08:53:07 -0400 From: Paul Mather <paul@gromit.dlib.vt.edu> To: Jeremy Chadwick <freebsd@jdc.parodius.com> Cc: Ed Schouten <ed@80386.nl>, freebsd-stable@FreeBSD.org, Alex Dupre <ale@FreeBSD.org> Subject: Re: mysqld_safe holding open a pty/tty on FreeBSD (7.x and 8.x) Message-ID: <E04F963B-7AAF-4483-8B60-6BBA2AFCCD28@gromit.dlib.vt.edu> In-Reply-To: <20100930075616.GA11519@icarus.home.lan> References: <20100930065151.GA9634@icarus.home.lan> <20100930070333.GU87427@hoeg.nl> <20100930072819.GA10678@icarus.home.lan> <4CA43C91.5040000@FreeBSD.org> <20100930075616.GA11519@icarus.home.lan>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sep 30, 2010, at 3:56 AM, Jeremy Chadwick wrote: > The diff is pretty obvious/simple (2 line change), so the other > databases/mysqlXX-server ports can be upgraded in the same manner. >=20 > --- files/mysql-server.sh.in.orig 2010-03-27 03:24:53.000000000 = -0700 > +++ files/mysql-server.sh.in 2010-09-30 00:45:38.000000000 -0700 > @@ -35,8 +35,8 @@ > mysql_user=3D"mysql" > mysql_limits_args=3D"-e -U ${mysql_user}" > pidfile=3D"${mysql_dbdir}/`/bin/hostname`.pid" > -command=3D"%%PREFIX%%/bin/mysqld_safe" > -command_args=3D"--defaults-extra-file=3D${mysql_dbdir}/my.cnf = --user=3D${mysql_user} --datadir=3D${mysql_dbdir} --pid-file=3D${pidfile} = ${mysql_args} > /dev/null 2>&1 &" > +command=3D"/usr/sbin/daemon" > +command_args=3D"-c -f /usr/local/bin/mysqld_safe = --defaults-extra-file=3D${mysql_dbdir}/my.cnf --user=3D${mysql_user} = --datadir=3D${mysql_dbdir} --pid-file=3D${pidfile} ${mysql_args}" Shouldn't this be "-c -f %%PREFIX%%/bin/mysqld_safe ..." rather than = hard-coding /usr/local? > procname=3D"%%PREFIX%%/libexec/mysqld" > start_precmd=3D"${name}_prestart" > start_postcmd=3D"${name}_poststart" >=20 > --=20 > | Jeremy Chadwick jdc@parodius.com | > | Parodius Networking http://www.parodius.com/ | > | UNIX Systems Administrator Mountain View, CA, USA | > | Making life hard for others since 1977. PGP: 4BD6C0CB | Cheers, Paul.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?E04F963B-7AAF-4483-8B60-6BBA2AFCCD28>