Date: Tue, 8 Aug 2017 00:29:37 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: Warner Losh <imp@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r322196 - head/sys/geom Message-ID: <20170807212937.GJ1700@kib.kiev.ua> In-Reply-To: <201708072112.v77LCSxL001381@repo.freebsd.org> References: <201708072112.v77LCSxL001381@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Aug 07, 2017 at 09:12:28PM +0000, Warner Losh wrote:
> + LIST_FOREACH(gap, &pp->geom->aliases, ga_next) {
> + error = make_dev_alias_p(MAKEDEV_CHECKNAME | MAKEDEV_WAITOK, &adev, dev,
> + "%s", gap->ga_alias);
> + if (error) {
> + printf("%s: make_dev_alias_p() failed (name=%s, error=%d)\n",
> + __func__, gap->ga_alias, error);
> + continue;
> + }
> + adev->si_flags |= SI_UNMAPPED;
Why do you set the flag unconditionally ?
> + adev->si_iosize_max = dev->si_iosize_max;
> + adev->si_drv2 = dev->si_drv2;
And what are you trying to do by these initializations, including the
si_flags adjustment ?
Aliases cause creation of symlinks in the devfs populate loop, which
makes it impossible to access the alias cdevs.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170807212937.GJ1700>