Date: Mon, 22 Jan 2018 16:00:27 -0700 From: Warner Losh <imp@bsdimp.com> To: Ravi Pokala <rpokala@mac.com> Cc: Poul-Henning Kamp <phk@phk.freebsd.dk>, John Baldwin <jhb@freebsd.org>, Emmanuel Vadot <manu@bidouilliste.com>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r328257 - in head/sys: arm/broadcom/bcm2835 dts/arm modules Message-ID: <CANCZdfpq2QoG4EAj0VW2FF=4VXRv-qQKFfJTJerWH9YOwVoVBA@mail.gmail.com> In-Reply-To: <607B50C2-883C-4CAB-8860-483EC4E9A668@mac.com> References: <201801220710.w0M7AUm9091853@repo.freebsd.org> <88258.1516630050@critter.freebsd.dk> <20180122153003.664e1613bbf70ab49c5c1541@bidouilliste.com> <52374125.OgxafgljNu@ralph.baldwin.cx> <89102.1516649067@critter.freebsd.dk> <CANCZdfp6t6KrTkp=O7Z9crnAUZhFMr%2BW-92t9S480=OytJdpfg@mail.gmail.com> <607B50C2-883C-4CAB-8860-483EC4E9A668@mac.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jan 22, 2018 at 1:41 PM, Ravi Pokala <rpokala@mac.com> wrote: > >> I wonder if it would be too noisy if we allowed ->probe() to run on > disabled devices and reported something like: > >> > >> "foobar0: Matched disabled device <...>" > >> > >> (without calling ->attach()) > >> > >> That way you would know you loaded the right driver, rather than have > to guess > > > > I suspect that would be too noisy. It would be better to just run probe, > but then have newbus report it's disabled so we never go onto attach. > > I think a "Matched disabled device" message under bootverbose would be > reasonable. > I think even bootverbose it's insane. Or I don't understand what the real ask is. Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfpq2QoG4EAj0VW2FF=4VXRv-qQKFfJTJerWH9YOwVoVBA>