Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 5 Nov 2013 19:49:53 +0000 (UTC)
From:      John Baldwin <jhb@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r257715 - head/etc
Message-ID:  <201311051949.rA5Jnr1c013300@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: jhb
Date: Tue Nov  5 19:49:53 2013
New Revision: 257715
URL: http://svnweb.freebsd.org/changeset/base/257715

Log:
  Don't explicitly invoke ifn_start on new child interfaces (vaps and
  subinterfaces) after they are created.  Interfaces are already started
  by devd invoking /etc/pccard_ether when they are created, so the explicit
  calls in childif_create() resulted in interfaces being started twice.
  
  Note that interfaces created via cloned_interfaces are not explicitly
  started but depend on the devd mechanism already.
  
  MFC after:	1 week

Modified:
  head/etc/network.subr

Modified: head/etc/network.subr
==============================================================================
--- head/etc/network.subr	Tue Nov  5 19:40:34 2013	(r257714)
+++ head/etc/network.subr	Tue Nov  5 19:49:53 2013	(r257715)
@@ -1429,9 +1429,6 @@ childif_create()
 			fi
 			${IFCONFIG_CMD} $i name $child && cfg=0
 		fi
-		if autoif $child; then
-			ifn_start $child
-		fi
 	done
 
 	# Create vlan interfaces
@@ -1455,9 +1452,6 @@ childif_create()
 				${IFCONFIG_CMD} $i name $child && cfg=0
 			fi
 		fi
-		if autoif $child; then
-			ifn_start $child
-		fi
 	done
 
 	return ${cfg}



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201311051949.rA5Jnr1c013300>