Date: Tue, 22 Sep 2015 12:43:01 +0300 From: Slawa Olhovchenkov <slw@zxy.spb.ru> To: Dimitry Andric <dim@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r288099 - head/contrib/binutils/opcodes Message-ID: <20150922094301.GW3158@zxy.spb.ru> In-Reply-To: <201509220935.t8M9ZZfD051027@repo.freebsd.org> References: <201509220935.t8M9ZZfD051027@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Sep 22, 2015 at 09:35:35AM +0000, Dimitry Andric wrote: > Author: dim > Date: Tue Sep 22 09:35:35 2015 > New Revision: 288099 > URL: https://svnweb.freebsd.org/changeset/base/288099 > > Log: > In binutils' arm-dis.c, avoid left-shifting a negative number. > > Submitted by: dan.mcgregor_usask.ca (Dan McGregor) > MFC after: 3 days > Differential Revision: https://reviews.freebsd.org/D3376 > > Modified: > head/contrib/binutils/opcodes/arm-dis.c > > Modified: head/contrib/binutils/opcodes/arm-dis.c > ============================================================================== > --- head/contrib/binutils/opcodes/arm-dis.c Tue Sep 22 07:40:55 2015 (r288098) > +++ head/contrib/binutils/opcodes/arm-dis.c Tue Sep 22 09:35:35 2015 (r288099) > @@ -1767,7 +1767,7 @@ print_insn_coprocessor (bfd_vma pc, stru > > /* Is ``imm'' a negative number? */ > if (imm & 0x40) > - imm |= (-1 << 7); > + imm |= -(1 << 7); May be (~0 << 7) is more simple to understund?
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150922094301.GW3158>