Date: Thu, 3 Sep 2009 13:54:16 +0200 From: Joerg Sonnenberger <joerg@britannica.bec.de> To: svn-src-all@freebsd.org Cc: des@freebsd.org Subject: Re: svn commit: r196752 - head/lib/libc/stdtime Message-ID: <20090903115416.GB448@britannica.bec.de> In-Reply-To: <86zl9c9z05.fsf@ds4.des.no> References: <200909020456.n824uUqQ082136@svn.freebsd.org> <20090902070808.GA1290@arthur.nitro.dk> <20090902084002.GA17325@nagual.pp.ru> <867hwgcwvo.fsf@ds4.des.no> <20090903084325.GA65192@nagual.pp.ru> <86zl9c9z05.fsf@ds4.des.no>
index | next in thread | previous in thread | raw e-mail
On Thu, Sep 03, 2009 at 11:08:26AM +0200, Dag-Erling Smørgrav wrote: > @@ -65,6 +65,15 @@ > .It "\&031\ EM \t032\ SUB \t033\ ESC \t034\ FS \t035\ GS" > .It "\&036\ RS \t037\ US \t177\ DEL" > .El > +.Pp > +.Em NOTE : > +if the value passed to the > +.Fn iscntrl > +function is a > +.Vt signed char , > +as is usually the case, it must be cast to an > +.Vt unsigned char > +to avoid sign-extension errors. > .Sh RETURN VALUES > The > .Fn iscntrl This is actually not good enough. ISO C doesn't specify whether plain char is signed or unsigned. Also, isascii is the only exception to this rule, so the change for that is wrong. Joerghome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090903115416.GB448>