Date: Wed, 14 Jun 2017 11:12:55 -0500 From: Alan Cox <alc@rice.edu> To: rgrimes@freebsd.org Cc: Hans Petter Selasky <hps@selasky.org>, Alan Cox <alc@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r319905 - in head/sys: kern sys Message-ID: <06a51008-6cb1-fbc1-500b-c5821b306649@rice.edu> In-Reply-To: <201706141552.v5EFq5rJ062076@pdx.rh.CN85.dnsmgr.net> References: <201706141552.v5EFq5rJ062076@pdx.rh.CN85.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 06/14/2017 10:52, Rodney W. Grimes wrote:
> [ Charset UTF-8 unsupported, converting... ]
>> On 06/14/2017 06:04, Hans Petter Selasky wrote:
>>> On 06/13/17 19:49, Alan Cox wrote:
>>>> +#define bitcount64(x) __bitcount64((uint64_t)(x))
>>> bitcount64() is already defined by sys/libkern.h - use that?=20
>> This snippet appears in code that is only used when compiling this fil=
e
>> as a user-space application for testing. Attempting to use
>> sys/libkern.h in the user-space compilation provoked warnings.
> Could we please add a comment to this define indicating this?
>
This snippet is enclosed in the #else of an #ifdef _KERNEL, where the
entire #ifdef _KERNEL is not that long, so if you're looking at the
actual file rather than a diff, it's pretty clear. And just a few lines
above the #ifdef _KERNEL is the comment:
* =
=20
* This code can be compiled stand-alone for
debugging. =20
*/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?06a51008-6cb1-fbc1-500b-c5821b306649>