Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 15 Jun 2010 17:19:39 -0400
From:      John Baldwin <jhb@freebsd.org>
To:        Jack F Vogel <jfv@freebsd.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r209218 - head/sys/dev/e1000
Message-ID:  <201006151719.39275.jhb@freebsd.org>
In-Reply-To: <201006152111.o5FLBpPa095035@svn.freebsd.org>
References:  <201006152111.o5FLBpPa095035@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday 15 June 2010 5:11:51 pm Jack F Vogel wrote:
> Author: jfv
> Date: Tue Jun 15 21:11:51 2010
> New Revision: 209218
> URL: http://svn.freebsd.org/changeset/base/209218
> 
> Log:
>   Change to have legacy interrupts use the same
>   handler had a flaw, thanks to John Baldwin for
>   finding it. Change which queue legacy tasks are
>   enqueued on.
>   
>   MFC: soonest

Thanks.

> Modified: head/sys/dev/e1000/if_igb.h
> 
==============================================================================
> --- head/sys/dev/e1000/if_igb.h	Tue Jun 15 21:00:53 2010	(r209217)
> +++ head/sys/dev/e1000/if_igb.h	Tue Jun 15 21:11:51 2010	(r209218)
> @@ -382,7 +382,6 @@ struct adapter {
>  	int		min_frame_size;
>  	struct mtx	core_mtx;
>  	int		igb_insert_vlan_header;
> -	struct task     rxtx_task;
>  	struct taskqueue *tq;	/* adapter task queue */
>          u16		num_queues;

I think the 'tq' pointer here is unused now and can be dropped.

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201006151719.39275.jhb>