Date: Tue, 05 Jan 2010 13:12:43 +0000 From: Bruce Simpson <bms@incunabulum.net> To: Luigi Rizzo <rizzo@iet.unipi.it> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Michael Tuexen <tuexen@freebsd.org> Subject: Re: moving sctp to a separate directory ? (Re: svn commit: r201523 - head/sys/netinet) Message-ID: <4B433ACB.5040902@incunabulum.net> In-Reply-To: <20100104222323.GA49068@onelab2.iet.unipi.it> References: <201001041825.o04IPcXb043347@svn.freebsd.org> <20100104190024.GA47532@onelab2.iet.unipi.it> <517EF225-7EEB-4844-A0AD-019AD72F9403@freebsd.org> <20100104222323.GA49068@onelab2.iet.unipi.it>
next in thread | previous in thread | raw e-mail | index | archive | help
On 04/01/2010 22:23, Luigi Rizzo wrote:
> I also think that the name of the new directory or the exact percentage of
> ipv4-ness or netinet-ness of the sctp* and tcp* and multicast* stuff
> is irrelevant. Moving directories with svn is so easy that we should not
> worry even if we need a couple of attempts to find a good name.
>
On a related, but different, note:
I actually think that the mcast code could have benefitted from C++
style templates. There's a lot of code duplication between the IPv6 and
IPv4 versions of those modules.
It's the entry points, and argument types, which ultimately
mattered, so when integrating the MLD implementation into FreeBSD back
last April, I found myself doing 'cp', 'sed', and manual edits mostly to
deal with only *slight* semantic differences between IPv4 and IPv6 in
the kernel.
Having said all that, it seems to me like the netinet/ code overall
could do with being split up further into individual files, to make it
more manageable. This has sort of already happened as time has gone on.
cheers,
BMS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4B433ACB.5040902>