Date: Thu, 5 May 2011 19:22:52 +0300 From: Kostik Belousov <kostikbel@gmail.com> To: mdf@freebsd.org Cc: Attilio Rao <attilio@freebsd.org>, svn-src-projects@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r221499 - in projects/largeSMP: gnu/usr.bin/gdb/kgdb lib/libmemstat sys/amd64/acpica sys/amd64/amd64 sys/amd64/include sys/arm/arm sys/arm/include sys/cddl/dev/cyclic/i386 sys/cddl/dev/... Message-ID: <20110505162252.GX48734@deviant.kiev.zoral.com.ua> In-Reply-To: <BANLkTikNwVQdGHOr1gbpajVXfvWA1LovqA@mail.gmail.com> References: <201105051439.p45EdEgC003770@svn.freebsd.org> <BANLkTikNwVQdGHOr1gbpajVXfvWA1LovqA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Thu, May 05, 2011 at 08:56:31AM -0700, mdf@freebsd.org wrote: > On Thu, May 5, 2011 at 7:39 AM, Attilio Rao <attilio@freebsd.org> wrote: > > Author: attilio > > Date: Thu May 5 14:39:14 2011 > > New Revision: 221499 > > URL: http://svn.freebsd.org/changeset/base/221499 > > > > Log: > > Commit the support for removing cpumask_t and replacing it directly with > > cpuset_t objects. > > I suppose it's a bit of a bikeshed issue, but I found a few of the > names a little confusing. I'd prefer: > > s/CPU_OVERLAP/CPU_INTERSECT > s/CPU_NAND/CPU_CLRSET (to mirror CPU_CLR) or CPU_SUBTRACT or CPU_DIFFERENCE > > Possibly also s/CPU_OR/CPU_SETSET or CPU_UNION. In general I found > the naming a bit confusing since it seemed that, though these are > declared as a set of cpus (cpuset_t) the operation names aren't > set-type operations, like UNION, INTERSECT, DIFFERENCE, etc. > > It looks like the names have been around for a while, but I suspect > they don't see much use until this branch. There is a set of operations on the signal masks that are very similar to the cpuset_t, and at least nand operation is named consistently between them. [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iEYEARECAAYFAk3CztwACgkQC3+MBN1Mb4j1vgCg8yD8v7zc6LpNy608QlggCJzD gk4AoOgvgOGBmEhxZ/y/e0GoLsd6ZZQT =wQKx -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110505162252.GX48734>