Date: Wed, 21 Feb 2001 22:11:51 +0100 From: Jesper Skriver <jesper@skriver.dk> To: Ben Smithurst <csxbcs@comp.leeds.ac.uk> Cc: Poul-Henning Kamp <phk@critter.freebsd.dk>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/share/man/man9 style.9 Message-ID: <20010221221151.L75376@skriver.dk> In-Reply-To: <20010221201615.A25231@comp.leeds.ac.uk>; from csxbcs@comp.leeds.ac.uk on Wed, Feb 21, 2001 at 08:16:16PM %2B0000 References: <200102211210.f1LCAKN41997@freefall.freebsd.org> <1166.982760630@critter> <20010221201615.A25231@comp.leeds.ac.uk>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Feb 21, 2001 at 08:16:16PM +0000, Ben Smithurst wrote: > Poul-Henning Kamp wrote: > > > Better, and more readable: > > > > error = function(a1, a2); > > if (error != 0) > > Well that's a matter of opinion, but I suppose it's easily changed. :-) > I figured there's enough use of 'if ((var = func()) != 0)' in FreeBSD > that everyone knows exactly what it does and yours isn't really any more > readable. But it can easily be changed if people generally agree with > you. Me newbee think phk's version is much more readable ... /Jesper -- Jesper Skriver, jesper(at)skriver(dot)dk - CCIE #5456 Work: Network manager @ AS3292 (Tele Danmark DataNetworks) Private: FreeBSD committer @ AS2109 (A much smaller network ;-) One Unix to rule them all, One Resolver to find them, One IP to bring them all and in the zone to bind them. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010221221151.L75376>