Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 6 Feb 2002 01:45:29 +0300
From:      "Andrey A. Chernov" <ache@nagual.pp.ru>
To:        Mark Murray <mark@grondar.za>
Cc:        des@freebgsd.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/lib/libpam/modules/pam_unix pam_unix.c
Message-ID:  <20020205224527.GA9394@nagual.pp.ru>
In-Reply-To: <200202052235.g15MZYs33989@greenpeace.grondar.org>
References:  <20020205220620.GD8579@nagual.pp.ru> <200202052235.g15MZYs33989@greenpeace.grondar.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Feb 05, 2002 at 22:35:29 +0000, Mark Murray wrote:
> 
> In my opinion, your program was a god example of how _not_ to do it. :-)

Program just knows nothing about undocumented PAM internal random() 
clobbering. And don't need to know anything about that in general. Do you 
expect that each writer must analyze pam_unix() code before starting using 
random() in his program? If so, it should be documented even in random(4) 
manpage.

General rule is: general purpose libraries should minimize unpredicatble
and undocumented side effects.

-- 
Andrey A. Chernov
http://ache.pp.ru/

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020205224527.GA9394>