Date: Thu, 8 Jul 2021 10:30:06 +0800 From: Li-Wen Hsu <lwhsu@freebsd.org> To: Randall Stewart <rrs@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: d7955cc0ffdf - main - tcp: HPTS performance enhancements Message-ID: <CAKBkRUwjo2jvnMYBYdtcmyxF=-PY68R9Dp4wHYpZEXVKuz54tg@mail.gmail.com> In-Reply-To: <202107071122.167BMe50059361@gitrepo.freebsd.org> References: <202107071122.167BMe50059361@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jul 7, 2021 at 7:22 PM Randall Stewart <rrs@freebsd.org> wrote: > > The branch main has been updated by rrs: > > URL: https://cgit.FreeBSD.org/src/commit/?id=d7955cc0ffdf9fb58013245a6f181c757574ea0a > > commit d7955cc0ffdf9fb58013245a6f181c757574ea0a > Author: Randall Stewart <rrs@FreeBSD.org> > AuthorDate: 2021-07-06 19:23:22 +0000 > Commit: Randall Stewart <rrs@FreeBSD.org> > CommitDate: 2021-07-07 11:22:35 +0000 > > tcp: HPTS performance enhancements > > HPTS drives both rack and bbr, and yet there have been many complaints > about performance. This bit of work restructures hpts to help reduce CPU > overhead. It does this by now instead of relying on the timer/callout to > drive it instead use user return from a system call as well as lro flushes > to drive hpts. The timer becomes a backstop that dynamically adjusts > based on how "late" we are. > > Reviewed by: tuexen, glebius > Sponsored by: Netflix Inc. > Differential Revision: https://reviews.freebsd.org/D31083 > --- > sys/kern/subr_trap.c | 10 + > sys/netinet/in_pcb.h | 4 +- > sys/netinet/tcp_hpts.c | 1309 +++++++++++++++++++++++++---------------- > sys/netinet/tcp_hpts.h | 99 +++- > sys/netinet/tcp_lro.c | 28 +- > sys/netinet/tcp_lro.h | 10 +- > sys/netinet/tcp_stacks/bbr.c | 6 +- > sys/netinet/tcp_stacks/rack.c | 22 +- > 8 files changed, 931 insertions(+), 557 deletions(-) Hi Randall. I think this breaks 32 bits platforms builds, for example: https://ci.freebsd.org/job/FreeBSD-main-i386-LINT/18214/console https://ci.freebsd.org/job/FreeBSD-main-armv7-LINT/1192/console Can you help check this? Thanks! Best, Li-Wen
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAKBkRUwjo2jvnMYBYdtcmyxF=-PY68R9Dp4wHYpZEXVKuz54tg>