Date: Thu, 1 Dec 2011 01:43:49 +0000 From: Alexander Best <arundel@freebsd.org> To: Garrett Cooper <yanegomi@gmail.com> Cc: Doug Barton <dougb@freebsd.org>, Warner Losh <imp@freebsd.org>, current@freebsd.org, Warner Losh <imp@bsdimp.com> Subject: Re: Remove debug echo Message-ID: <20111201014349.GA61475@freebsd.org> In-Reply-To: <CAGH67wQFecLHFsANmWFSr6e%2B99P1QY9erNzoXFmJG40RntFazQ@mail.gmail.com> References: <201111291607.26546.jhb@freebsd.org> <A6C0CFB3-A657-41AA-8A2E-172D95BD0F98@bsdimp.com> <20111201002515.GA50028@freebsd.org> <CAGH67wQFecLHFsANmWFSr6e%2B99P1QY9erNzoXFmJG40RntFazQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed Nov 30 11, Garrett Cooper wrote:
> On Wed, Nov 30, 2011 at 4:25 PM, Alexander Best <arundel@freebsd.org> wrote:
> > On Tue Nov 29 11, Warner Losh wrote:
> >> kill it.
> >>
> >> Warner
> >> On Nov 29, 2011, at 2:07 PM, John Baldwin wrote:
> >>
> >> > Any objections to this? It removes a weird line during 'make -s buildworld'
> >> > output and I think it was debugging accidentally left in in 213077 by Warner:
> >> >
> >> > Index: newvers.sh
> >> > ===================================================================
> >> > --- newvers.sh (revision 228074)
> >> > +++ newvers.sh (working copy)
> >> > @@ -99,7 +99,6 @@ for dir in /bin /usr/bin /usr/local/bin; do
> >> > done
> >> >
> >> > if [ -n "$svnversion" ] ; then
> >> > - echo "$svnversion"
> >> > svn=`cd ${SYSDIR} && $svnversion`
> >> > case "$svn" in
> >> > [0-9]*) svn=" r${svn}" ;;
> >
> > also...
> >
> > when running buildkernel via 'make -s', do we really need all those module
> > printfs? i see messages for "cleandir", "obj", "depend" and "all". i think for
> > 'make -s', that's pure overkill!
> >
> > for a GENERIC kernel, 'make' enters ~ 670 module dirs. take that times 4 and
> > you'll get 2680 lines of output. not really *silent*, is it? ;)
>
> pmake sucks as far as diagnostic output is concerned when compared
> with gmake. I'd rather not have to fish through with -j1 (if I'm lucky
> and it's not a race) to determine what directory created the "Error
> Code" output. With the printouts discussed here, at least you have a
> chance at determining what the issue was.
> Maybe it's just me, but I like noisy builds -- otherwise the
> amount of time I have to spend root-causing the issue becomes
> expensive.
ehmmm...a noisy silent flag? i totally agree, if we're talking about 'make' in
its default mode, but what's the point of a silent flag, if it produces > 2500
lines of output? nobody uses the -s flag for diagnostics. its purpose is to
build a kernel without producing a lot of output and also not fiddling with
stdout/stderr to achieve that goal.
cheers.
alex
> Thanks,
> -Garrett
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20111201014349.GA61475>