Date: Wed, 09 Sep 2009 20:47:27 -0700 From: Tim Kientzle <kientzle@freebsd.org> To: Andrey Chernov <ache@nagual.pp.ru>, Roman Divacky <rdivacky@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r196981 - head/usr.bin/unzip Message-ID: <4AA876CF.8000903@freebsd.org> In-Reply-To: <20090909163937.GB37924@nagual.pp.ru> References: <200909081555.n88FtDwe052523@svn.freebsd.org> <20090909132616.GA35808@nagual.pp.ru> <4AA7C6B9.1020600@freebsd.org> <20090909163937.GB37924@nagual.pp.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
Andrey Chernov wrote: > On Wed, Sep 09, 2009 at 08:16:09AM -0700, Tim Kientzle wrote: >> Since this is only to support -a (which does end-of-line >> conversions), I would suggest using a rather different >> set of heuristics that examines end-of-line sequences >> and control characters only: >> * Any byte value <31 that's not CR or LF: not text > > More carefully - <32, TAB and ^Z (MSDOS EOT) must be > allowed too and perhaps ^L. Yes, but be careful. Remember that -a processing is destructive; it's better to err on the side of marking something binary. Tim
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4AA876CF.8000903>