Date: Sun, 4 Sep 2011 15:09:17 +0200 From: Attilio Rao <attilio@freebsd.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r225372 - head/sys/kern Message-ID: <CAJ-FndDa=xmvrcn9CdgMvDZ_vG3pjUdFqLH=Q%2BVK%2BSWjvGFO9g@mail.gmail.com> In-Reply-To: <201109041307.p84D72GY092462@svn.freebsd.org> References: <201109041307.p84D72GY092462@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
2011/9/4 Attilio Rao <attilio@freebsd.org>: > Author: attilio > Date: Sun Sep =C2=A04 13:07:02 2011 > New Revision: 225372 > URL: http://svn.freebsd.org/changeset/base/225372 > > Log: > =C2=A0Interrupts are disabled/enabled when entering and exiting the KDB c= ontext. > =C2=A0While this is generally good, it brings along a serie of problems, > =C2=A0like clocks going off sync and in presence of SW_WATCHDOG, watchdog= s > =C2=A0firing without a good reason (missed hardclock wdog ticks update). Also please notice that intr enable/disable happens in the wrong way as it is done via the MD (x86 specific likely) interface. This is wrong for 2 reasons: 1) There may be some codepaths leading to explicit preemption 2) It should really use an MI interface The right way to do this should be via spinlock_enter(). Attilio --=20 Peace can only be achieved by understanding - A. Einstein
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-FndDa=xmvrcn9CdgMvDZ_vG3pjUdFqLH=Q%2BVK%2BSWjvGFO9g>