Date: Sat, 24 Jun 2000 00:10:14 -0600 From: Warner Losh <imp@village.org> To: Assar Westerlund <assar@sics.se> Cc: Garrett Wollman <wollman@khavrinen.lcs.mit.edu>, current@FreeBSD.ORG, kris@FreeBSD.ORG Subject: Re: vnode_if.h: how should it be done ? Message-ID: <200006240610.AAA01831@harmony.village.org> In-Reply-To: Your message of "22 Jun 2000 05:57:01 %2B0200." <5llmzyqsfm.fsf@assaris.sics.se> References: <5llmzyqsfm.fsf@assaris.sics.se> <5ln1kesdkq.fsf@assaris.sics.se> <200006220345.XAA42447@khavrinen.lcs.mit.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <5llmzyqsfm.fsf@assaris.sics.se> Assar Westerlund writes:
: The problem is that the source files are hidden in the kernel source
: directory and not installed. Where should vnode_if.{src,pl} get
: installed? It seems much simpler just to install vnode_if.h in
: /usr/include/sys. Patch appended.
No. We don't install kenrel internal files. Use SYSDIR instead.
: + ${INSTALL} -C -o ${BINOWN} -g ${BINGRP} -m 444 \
: + ${.OBJDIR}/vnode_if.h \
: + ${DESTDIR}/usr/include/sys
I object to this part of the patch. We shouldn't install this file.
It isn't needed by anything outside of the kernel/drivers. For
drivers, it should be built automatically as part of the modules build
system ala the *_if.m stuff.
Warner
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200006240610.AAA01831>