Date: Wed, 27 Mar 2002 11:29:49 +0000 From: Mark Murray <mark@grondar.za> To: Bruce Evans <bde@zeta.org.au> Cc: audit@FreeBSD.ORG Subject: Re: Library __progname cleanups - commit candidate Message-ID: <200203271129.g2RBTnQE007451@grimreaper.grondar.org> In-Reply-To: <20020327214800.B3808-100000@gamplex.bde.org> ; from Bruce Evans <bde@zeta.org.au> "Wed, 27 Mar 2002 21:55:11 %2B1100." References: <20020327214800.B3808-100000@gamplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> > > too carefully there, so they don't already cover <stdlib.h>). > > > > You don't think this "standard way" could be documented somewhere, do you? > > The logs for the commits that added it should be sufficient. There are > hundreds of examples. "Should be" != "Is". Grovelling out the right example is an exercise in futility, as for each example there is usually a counterexample. > > > > - snprintf(str, sizeof(str), "%s - Warning: Thread %p attempted to lock %p from %s (%d) was left locked from %s (%d)\n", __progname, curthread, lck, fname, lineno, lck->fname, lck->lineno); > > > > + snprintf(str, sizeof(str), "%s - Warning: Thread %p attempted to lock %p from %s (%d) was left locked from %s (%d)\n", _getprogname(), curthread, lck, fname, lineno, lck->fname, lck->lineno); > > > > > > Disgustingly long line longer than before. > > > > I'd prefer to solve this with an appropriate indent(1). > > FreeBSD's indent(1) doesn't understand long lines at all. FSF/GNU indent is much better, and large parts of it are still BSD licensed. I'm working on backporting those bits. M -- o Mark Murray \_ O.\_ Warning: this .sig is umop ap!sdn To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200203271129.g2RBTnQE007451>