Date: Mon, 18 Apr 2011 08:17:44 -0700 From: mdf@FreeBSD.org To: John Baldwin <jhb@freebsd.org> Cc: freebsd-current@freebsd.org, Nick Ulen <uncle@wolfman.devio.us> Subject: Re: `hw.acpi.thermal.tz0.temperature' disappeared Message-ID: <BANLkTi=MZ3Pn5Kit-YcKGafoJMCf5w6AyQ@mail.gmail.com> In-Reply-To: <201104180805.40743.jhb@freebsd.org> References: <20110416155122.GA29309@wolfman.devio.us> <201104180805.40743.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Apr 18, 2011 at 5:05 AM, John Baldwin <jhb@freebsd.org> wrote: > On Saturday, April 16, 2011 11:51:22 am Nick Ulen wrote: >> FreeBSD was successfully upgraded. >> >> uname -v >> FreeBSD 9.0-CURRENT #0: Mon Apr 11 18:14:36 MSD 2011 >> root@test:/usr/obj/usr/src/sys/GENERIC >> >> Everything seems to be working well except >> `hw.acpi.thermal.tz0.temperature' disappeared from the list of available >> sysctl variables. >> >> sysctl hw.acpi.thermal. >> >> hw.acpi.thermal.min_runtime: 0 >> hw.acpi.thermal.polling_rate: 10 >> hw.acpi.thermal.user_override: 0 >> hw.acpi.thermal.tz0.active: -1 >> hw.acpi.thermal.tz0.passive_cooling: 0 >> hw.acpi.thermal.tz0.thermal_flags: 0 >> hw.acpi.thermal.tz0._PSV: -1 >> hw.acpi.thermal.tz0._HOT: -1 >> hw.acpi.thermal.tz0._CRT: 90.0C >> hw.acpi.thermal.tz0._TC1: -1 >> hw.acpi.thermal.tz0._TC2: -1 >> hw.acpi.thermal.tz0._TSP: -1 >> >> output from: >> =A0sysctl -a |grep acpi >> is here: https://privatepaste.com/ca08d4658b > > I suspect it is still there, but sysctl doesn't know how to display it > anymore. =A0This is probably due to the changes with formatting of sysctl > information. =A0mdf@ is probably responsible in that case. > > =A0 =A0SYSCTL_ADD_OPAQUE(&sc->tz_sysctl_ctx, SYSCTL_CHILDREN(sc->tz_sysct= l_tree), > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0OID_AUTO, "temperature", CTLFL= AG_RD, &sc->tz_temperature, > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0sizeof(sc->tz_temperature), "I= K", > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0"current thermal zone temperat= ure"); Oops, yes. The change in r217586 required the type to be set to CTLTYPE_INT to print as format IK. My grep of the source tree shows that acpi_thermal.c is the only affected source file that was using OPAQUE. I'm testing out the fix now. Thanks, matthew
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?BANLkTi=MZ3Pn5Kit-YcKGafoJMCf5w6AyQ>