Date: Tue, 15 Jul 2025 09:40:18 -0700 From: Gleb Smirnoff <glebius@freebsd.org> To: Mark Johnston <markj@freebsd.org>, alc@freebsd.org, kib@freebsd.org Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: fad79db40505 - main - vm_pageout: Remove a volatile qualifier from some vm_domain members Message-ID: <aHaEcqEoH9ZpUf7X@cell.glebi.us> In-Reply-To: <202507151519.56FFJ4FS013944@gitrepo.freebsd.org> References: <202507151519.56FFJ4FS013944@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jul 15, 2025 at 03:19:04PM +0000, Mark Johnston wrote: M> The branch main has been updated by markj: M> M> URL: https://cgit.FreeBSD.org/src/commit/?id=fad79db405052f3faad7184ea2c8bfe9f92a700d M> M> commit fad79db405052f3faad7184ea2c8bfe9f92a700d M> Author: Mark Johnston <markj@FreeBSD.org> M> AuthorDate: 2025-07-15 15:16:40 +0000 M> Commit: Mark Johnston <markj@FreeBSD.org> M> CommitDate: 2025-07-15 15:16:40 +0000 M> M> vm_pageout: Remove a volatile qualifier from some vm_domain members M> M> These are always accessed using atomic(9) intrinsics, so do not need the M> qualifier. No functional change intended. M> M> Reviewed by: alc, kib M> MFC after: 2 weeks M> Sponsored by: Modirum MDPay M> Sponsored by: Klara, Inc. M> Differential Revision: https://reviews.freebsd.org/D51322 What's the benefit of removing the qualifiers? They act as documentation and they match atomic(9) prototypes. To me this looks like removing a const qualifier with a reasoning that we use the variable only as an argument to functions that have const qualifier. -- Gleb Smirnoff
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?aHaEcqEoH9ZpUf7X>