Skip site navigation (1)Skip section navigation (2) 
Date:      Mon, 13 Sep 2004 22:09:40 -0700 (PDT)
From:      Matthew Dillon <dillon@apollo.backplane.com>
To:        current@freebsd.org
Subject:   Possible bug in softclock()
Message-ID:  <200409140509.i8E59epB001664@apollo.backplane.com>
next in thread | raw e-mail | index | archive | help 

    In softclock(), should this line:

	c->c_flags = (c->c_flags & ~CALLOUT_PENDING);

    be:

	c->c_flags = (c->c_flags & ~(CALLOUT_PENDING | CALLOUT_MPSAFE));

    ?

    Otherwise routines which call callout_reset() to reset the callout
    will always clear the CALLOUT_MPSAFE flag.  This won't hurt things,
    but it will make them more inefficient.

					-Matt
					Matthew Dillon 
					<dillon@backplane.com>

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200409140509.i8E59epB001664>