Date: Tue, 14 Dec 2010 03:09:14 -0500 From: "Mikhail T." <mi+thun@aldan.algebra.com> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports GIDs UIDs ports/net Makefile ports/net/minidlna Makefile distinfo pkg-descr pkg-plist ports/net/minidlna/files BSDmakefile config.h getifaddr.c minidlna.sh.in patch-2928850 patch-aa patch-ab patch-inline patch-minidlna.c patch-upnphttp ... Message-ID: <4D07262A.3020303@aldan.algebra.com> In-Reply-To: <20101214072748.GA70334@FreeBSD.org> References: <201012140611.oBE6B42j028412@repoman.freebsd.org> <20101214072748.GA70334@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 14.12.2010 02:27, Alexey Dokuchaev wrote:
> On Tue, Dec 14, 2010 at 06:11:04AM +0000, Mikhail Teterin wrote:
>> mi 2010-12-14 06:11:04 UTC
>>
>> Added files:
>> net/minidlna Makefile distinfo pkg-descr pkg-plist
>> net/minidlna/files BSDmakefile config.h getifaddr.c
>> minidlna.sh.in patch-2928850 patch-aa
>> patch-ab patch-inline patch-minidlna.c
>> patch-upnphttp pkg-message.in
>> scandir-patch
>> Log:
>> Add the port of minidlna -- the DLNA-speaking service.
>> (Took me 6 months to come up with the etc/rc.d/ script...)
> It's sad that during these 6 months you did not find few minutes to ask
> dougb@ to review it.
Why is dougb@ to be burdened reviewing these particular things?
Having done the actual heavy-lifting of porting this Linux-only piece of
software back in June, I published the port's shar and asked -- on
ports@ -- for somebody else to contribute the start-up script. For 6
months no one has and now, finally, got around to learning, how to do
this myself.
>> Revision Changes Path
>> 1.1 +11 -0 ports/net/minidlna/files/patch-aa (new)
>> 1.1 +9 -0 ports/net/minidlna/files/patch-ab (new)
> Apart from number of style bugs in the Makefile, can you explain why did
Portlint's only complaint is the single MASTER_SITE... Feel free to
submit patches.
> you go with `patch-xy' files, which is against current naming policy?
Because I felt like this color was matching this bike shed the best...
Because several naming styles exist currently and this particular one
reminds the audience of the good old times, when new ports -- especially
those, which provide unique and hitherto unavailable functionality --
were welcomed, rather than scolded for imaginary transgressions...
You are welcome.
-mi
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4D07262A.3020303>