Date: Wed, 24 Sep 2003 08:21:11 +0200 From: Stijn Hoop <stijn@win.tue.nl> To: Daniel Eischen <deischen@freebsd.org> Cc: Kris Kennaway <kris@obsecurity.org> Subject: Re: Initial list of ports that fail due to -pthread Message-ID: <20030924062111.GC95116@pcwin002.win.tue.nl> In-Reply-To: <Pine.GSO.4.10.10309240204030.2518-100000@pcnet5.pcnet.com> References: <20030924060135.GB95116@pcwin002.win.tue.nl> <Pine.GSO.4.10.10309240204030.2518-100000@pcnet5.pcnet.com>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Wed, Sep 24, 2003 at 02:11:53AM -0400, Daniel Eischen wrote: > On Wed, 24 Sep 2003, Stijn Hoop wrote: > > Just an idea (I hope this hasn't been said before in the mega thread but at > > least I didn't get it this way): > > > > - fix all ports to respect PTHREAD_LIBS _ON THE LINKING STAGE_ (so no > > global search & replace, for it shouldn't be used in compile command > > lines) > This sounds nice, but I don't know that there really is much > difference in changes needed. Well it avoids gcc warnings in case PTHREAD_LIBS == '-lkse'. That's about the only reason I can think of to make the distinction between compiling & linking. > > - keep '-pthread' as a compiler option, which maps to a NOOP for compiling > > and '-lpthread' (aka libkse) for linking > > That's already the case; -pthread never did anything on the > compile, only the link. OK, but let's keep it that way then. Isn't the removal of -pthread that started all this? > > - set PTHREAD_LIBS to the default value of -pthread > > - allow PTHREAD_LIBS to be set to something other, e.g. '-lthr', in > > /etc/make.conf (or the make command line) > > This is already the path that ports is going down :-) Well, great. Let's go and fix some ports then, and everybody will be happy :) But if this is really the way to go, we probably need some hack to bsd.port.mk to make PTHREAD_LIBS standard because otherwise every port that needs a threads library needs to have PTHREAD_LIBS hacks. --Stijn -- Help Wanted: Telepath. You know where to apply. [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.3 (FreeBSD) iD8DBQE/cTfXY3r/tLQmfWcRAsIPAKCYRVpnVzmKirg7JG2QUsmYUjAI3QCgm8l9 /8HelHGL1kVjZgiKC3bN95I= =Ov3S -----END PGP SIGNATURE-----home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030924062111.GC95116>