Date: Sat, 28 Feb 2009 11:25:05 +0000 (UTC) From: Alexander Motin <mav@FreeBSD.org> To: cvs-src-old@freebsd.org Subject: cvs commit: src/sys/dev/ata ata-all.c ata-all.h ata-disk.c atapi-cam.c atapi-cd.c atapi-fd.c atapi-tape.c Message-ID: <200902281125.n1SBPFl8070474@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
mav 2009-02-28 11:25:05 UTC FreeBSD src repository Modified files: sys/dev/ata ata-all.c ata-all.h ata-disk.c atapi-cam.c atapi-cd.c atapi-fd.c atapi-tape.c Log: SVN rev 189166 on 2009-02-28 11:25:05Z by mav Rework device probing by moving ata_getparam() call from ata_identify() to drivers' probe routines. It allows not to sleep and so not drop Giant inside ata_identify() critical section and so avoid crash if it reentered on request timeout. Reentering of probe call checked inside of it. Give device own knowledge about it's type (ata/atapi/atapicam). It is not a good idea to ask channel status for device type inside ata_getparam(). Add softc memory deallocation on device destruction. Revision Changes Path 1.302 +44 -39 src/sys/dev/ata/ata-all.c 1.141 +8 -0 src/sys/dev/ata/ata-all.h 1.214 +12 -0 src/sys/dev/ata/ata-disk.c 1.60 +8 -12 src/sys/dev/ata/atapi-cam.c 1.204 +12 -0 src/sys/dev/ata/atapi-cd.c 1.118 +13 -0 src/sys/dev/ata/atapi-fd.c 1.112 +12 -0 src/sys/dev/ata/atapi-tape.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200902281125.n1SBPFl8070474>