Date: Fri, 2 Aug 2013 14:23:39 -0700 From: Adrian Chadd <adrian@freebsd.org> To: Cedric GROSS <cg@cgross.info> Cc: freebsd-wireless@freebsd.org Subject: Re: [iwn] Review split 3 Message-ID: <CAJ-Vmok=bFVRVrnkdAA%2BcsXPKV6iE_jruMKs45KX1WB--eV=sg@mail.gmail.com> In-Reply-To: <00a601ce8c8a$f21570f0$d64052d0$@info> References: <007601ce8c73$2b508cf0$81f1a6d0$@info> <CAJ-Vmok8s%2BZmJonko8m7Vk7h8Bv1=eHfPmCWD2Oq6ybWwJkzxg@mail.gmail.com> <alpine.BSF.2.00.1307291206050.45456@wonkity.com> <00a601ce8c8a$f21570f0$d64052d0$@info>
next in thread | previous in thread | raw e-mail | index | archive | help
Committed ,thanks! -adrian On 29 July 2013 11:39, Cedric GROSS <cg@cgross.info> wrote: > > >> De : Warren Block [mailto:wblock@wonkity.com] >> Envoy=E9 : lundi 29 juillet 2013 20:11 >> =C0 : Adrian Chadd >> Cc : Cedric GROSS; freebsd-wireless@freebsd.org >> >> On Mon, 29 Jul 2013, Adrian Chadd wrote: >> >> > Hi! >> > >> > Cool! ok, the style niggles. >> > >> > * Your #define IWN_blah needs a TAB between #define and the IWN_blah >> > value. Right now you have spaces. > > Ok, I tough you need spaces between #define and values... > > standard single-include stuff : Done > $FreeBSD$ : Moved > > Each file is different. Really hard to find something common. Man 9 style= is > quite useful but enough precise for tab and space usage I think. > >> >> There is whitespace at the end of some of the comment lines also. >> >> textproc/igor will find problems like that: >> >> igor -R filename | less -RS > > Thanks for that Warren !
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-Vmok=bFVRVrnkdAA%2BcsXPKV6iE_jruMKs45KX1WB--eV=sg>