Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 8 Jan 1999 09:28:21 -0800 (PST)
From:      Steve Kargl <sgk@troutmask.apl.washington.edu>
To:        bde@zeta.org.au (Bruce Evans)
Cc:        cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, n_hibma@FreeBSD.ORG
Subject:   Re: cvs commit: src/gnu/usr.bin/binutils/strip Makefile
Message-ID:  <199901081728.JAA91509@troutmask.apl.washington.edu>
In-Reply-To: <199901081127.WAA29679@godzilla.zeta.org.au> from Bruce Evans at "Jan 8, 1999 10:27:20 pm"

next in thread | previous in thread | raw e-mail | index | archive | help
According to Bruce Evans:
> >  Modified files:
> >    gnu/usr.bin/binutils/strip Makefile 
> >  Log:
> >  Ignore return value for strip. Avoids make world going pop
> >  because of
> >  
> >  strip maybe_stripped
> >  strip: maybe_stripped: File format not recognized
> >  *** Error code 1
> >  
> >  in I/usr/src/gnu/usr.bin/binutils/strip
> 
> Hmm, usr.bin/strip already has this breakage (ignoring an error).
> Possible correct fixes:
> 
> - use `install -C' to get an atomic install and remove all the maybe_stripped
>   complications.  (Someday, `install' should always be atomic.)
> - remove "." from $PATH.
> - abort `make world' if "." is in $PATH.
> 

I agree with Bruce that ignoring the error isn't the correct
solution.  Aborting `make world' if "." is in $PATH should
be the default action with an admonishment of the person trying
to run `make world'.  God only knows (and maybe Bruce) what kind
of trojan horses that a malicious user can embedded within a
`make world'.

-- 
Steve

finger kargl@troutmask.apl.washington.edu
http://troutmask.apl.washington.edu/~clesceri/kargl.html

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199901081728.JAA91509>