Date: Tue, 25 Feb 2025 08:33:20 -0500 From: John Baldwin <jhb@FreeBSD.org> To: Eugene Grosbein <eugen@freebsd.org>, Zhenlei Huang <zlei@FreeBSD.org> Cc: "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org>, "Herbert J. Skuhra" <herbert@gojira.at> Subject: Re: git: 93b4a5445658 - main - netgraph: prevent panic with INVARIANTS-enabled kernel Message-ID: <fb3961e5-ae67-4410-ada0-34e8a9135926@FreeBSD.org> In-Reply-To: <e2f94055-75f9-1d74-b8cb-52ab763831bc@freebsd.org> References: <202502250722.51P7Mwnr064433@gitrepo.freebsd.org> <AD0130C9-5FB7-442D-8CBA-4E5F5ADD2C43@FreeBSD.org> <e2f94055-75f9-1d74-b8cb-52ab763831bc@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2/25/25 04:37, Eugene Grosbein wrote: > 25.02.2025 14:59, Zhenlei Huang wrote: > >>> commit 93b4a54456589e78dcd37f2db8333baff3f3f0b2 >>> Author: Eugene Grosbein <eugen@FreeBSD.org> >>> AuthorDate: 2025-02-25 07:18:29 +0000 >>> Commit: Eugene Grosbein <eugen@FreeBSD.org> >>> CommitDate: 2025-02-25 07:22:53 +0000 >>> >>> netgraph: prevent panic with INVARIANTS-enabled kernel >>> >>> This change makes NG_ABI_VERSION depend on INVARIANTS >>> in addition to NETGRAPH_DEBUG. >>> >>> PR: 257876 >> >> Maybe a wrong PR ? >> >> The PR 257876 is about port math/deal.ii , I do not see any relationship between it and netgraph(3) or netgraph(4). > > Sorry, paste error. Right number is 214624. The best way to probably rectify this is to go add a comment in PR 257876 saying that the commit in comment N (7 in this case) is for PR 214624. Then if someone in the future tries to look up the bug from the commit message that gives them the note in the right place to find the right PR. (We should perhaps codify this as the way to deal with PR mismatches in commit logs) -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?fb3961e5-ae67-4410-ada0-34e8a9135926>