Date: Mon, 11 Oct 2010 09:27:48 -0700 From: Julian Elischer <julian@freebsd.org> To: Hans Petter Selasky <hselasky@c2i.net> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, Weongyo Jeong <weongyo@freebsd.org>, "svn-src-user@freebsd.org" <svn-src-user@freebsd.org> Subject: Re: svn commit: r213540 - user/weongyo/usb/sys/dev/usb/net Message-ID: <4CB33B04.8070609@freebsd.org> In-Reply-To: <201010111739.25082.hselasky@c2i.net> References: <201010080152.o981q1gJ074407@svn.freebsd.org> <201010111739.25082.hselasky@c2i.net>
index | next in thread | previous in thread | raw e-mail
On 10/11/10 8:39 AM, Hans Petter Selasky wrote: > On Friday 08 October 2010 03:52:01 Weongyo Jeong wrote: >> Author: weongyo >> Date: Fri Oct 8 01:52:01 2010 >> New Revision: 213540 >> URL: http://svn.freebsd.org/changeset/base/213540 >> >> Log: >> o fixes a regression that setting the promiscuous mode should be >> happened at the taskqueue. It's to avoid a `sleepable after >> non-sleepable' because ioctl handler could be called with holding bpf >> mtx which is a default mutex. >> o defines SLEEPOUT_DRAIN_TASK helper. >> [...] > These taskqueues belong in the network stack and not the USB drivers! And > please understand that you cannot use taskqueues for these commands, because > the events can be executed out of order!!! sounds like we should add an option to taskqueues to fix this then. I'd rather fix the standard facility than make a new one. > --HPS >help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4CB33B04.8070609>