Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 15 Sep 2010 16:40:17 +0000 (UTC)
From:      Attilio Rao <attilio@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-projects@freebsd.org
Subject:   svn commit: r212674 - projects/sv/sys/netinet
Message-ID:  <201009151640.o8FGeHUM043102@svn.freebsd.org>

index | next in thread | raw e-mail

Author: attilio
Date: Wed Sep 15 16:40:17 2010
New Revision: 212674
URL: http://svn.freebsd.org/changeset/base/212674

Log:
  ether_set_broadcast() is just one line and just called once.
  Inline it directly as it cuts some code.
  
  Submitted by:	emaste

Modified:
  projects/sv/sys/netinet/netdump_client.c

Modified: projects/sv/sys/netinet/netdump_client.c
==============================================================================
--- projects/sv/sys/netinet/netdump_client.c	Wed Sep 15 16:37:31 2010	(r212673)
+++ projects/sv/sys/netinet/netdump_client.c	Wed Sep 15 16:40:17 2010	(r212674)
@@ -153,24 +153,6 @@ static int nd_polls=10000; /* Times to p
 static int nd_retries=10; /* Times to retransmit lost packets */
 
 /*
- * [ether_set_broadcast]
- *
- * Fills up an ethernet address as broadcast
- *
- * Parameters:
- *	addr	The ethernet address to be filled up
- *
- * Returns:
- *	void
- */
-static __inline void
-ether_set_broadcast(struct ether_addr *addr)
-{
-
-	memset(addr, 0xFF, ETHER_ADDR_LEN);
-}
-
-/*
  * [netdump_supported_nic]
  *
  * Checks for netdump support on a network interface
@@ -515,8 +497,8 @@ netdump_send_arp()
 	struct arphdr *ah;
 	struct ether_addr bcast;
 
-	ether_set_broadcast(&bcast);
-
+	/* Fill-up a broadcast address. */
+	memset(&bcast, 0xFF, ETHER_ADDR_LEN);
 	MGETHDR(m, M_DONTWAIT, MT_DATA);
 	if (m == NULL) {
 		printf("netdump_send_arp: Out of mbufs");


help

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201009151640.o8FGeHUM043102>