Date: Wed, 8 Sep 2004 09:07:41 -0400 From: Brian Fundakowski Feldman <green@FreeBSD.ORG> To: "M. Warner Losh" <imp@bsdimp.com> Cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/dev/usb ugen.c Message-ID: <20040908130741.GC928@green.homeunix.org> In-Reply-To: <20040908.012031.93204322.imp@bsdimp.com> References: <200409080713.i887Dd54058789@repoman.freebsd.org> <20040908.012031.93204322.imp@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Sep 08, 2004 at 01:20:31AM -0600, M. Warner Losh wrote: > In message: <200409080713.i887Dd54058789@repoman.freebsd.org> > Warner Losh <imp@FreeBSD.org> writes: > : imp 2004-09-08 07:13:39 UTC > : > : FreeBSD src repository > : > : Modified files: > : sys/dev/usb ugen.c > : Log: > : Back out 1.88. > 1.87 I mean. > : The reference counts are there to block detach until the sleepers in > : read/write/ioctl have gotten out, not to prevent the open device from > : going away. Restore the old behavior so that we have a chance to wake > : up sleepers when the usb device goes away, so they can properly return > : EIO back to the caller when this happens. > : > : Otherwise, we have a guarnateed panic waiting to happen when a device > : detaches with an active read channel. > : > : This should be merged to 5 asap. Now I'll get guaranteed panics using both my Palm and any CardBus hardware. -- Brian Fundakowski Feldman \'[ FreeBSD ]''''''''''\ <> green@FreeBSD.org \ The Power to Serve! \ Opinions expressed are my own. \,,,,,,,,,,,,,,,,,,,,,,\
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040908130741.GC928>