Date: Fri, 20 Nov 2009 09:13:49 -0600 From: Nathan Whitehorn <nwhitehorn@freebsd.org> To: Bruce Evans <brde@optusnet.com.au> Cc: svn-src-projects@freebsd.org, =?ISO-8859-1?Q?Dag-Erling_Sm=F8rgrav?= <des@des.no>, src-committers@freebsd.org Subject: Re: svn commit: r199501 - projects/ppc64/sys/compat/freebsd32 Message-ID: <4B06B22D.60607@freebsd.org> In-Reply-To: <20091120184250.O13158@delplex.bde.org> References: <200911190120.nAJ1KGBA089661@svn.freebsd.org> <20091119194149.L12648@delplex.bde.org> <86ws1m647w.fsf@ds4.des.no> <20091120184250.O13158@delplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Bruce Evans wrote: > On Thu, 19 Nov 2009, [utf-8] Dag-Erling Smørgrav wrote: > >> Bruce Evans <brde@optusnet.com.au> writes: >>> This seems to have been generated from syscalls.master 199501, not the >>> claimed rev. Similarly for all other generated files. >> >> Common mistake: he regenerated them before committing. > > Too often made by new committers :-). And especially new committers seduced by the atomicity of multi-file commits in subversion... I'll do this in two steps when this eventually gets merged to head. Thanks for pointing it out! >> It would be neat[tm] if we had a post-commit hook to automatically >> regenerate these files... > > Maybe more should be generated on demand. Some of the generated syscall > files are special in being used by libc as well as kernels, but most > aren't. That would be really nice. A similar thing that would be nice would be if there were a post-commit hook that showed up at the same time to prevent you from modifying auto-generated files. -Nathan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4B06B22D.60607>