Date: Tue, 20 Feb 2018 13:42:41 +0200 From: Konstantin Belousov <kostikbel@gmail.com> To: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net> Cc: Mateusz Guzik <mjg@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r329639 - head/sys/kern Message-ID: <20180220114241.GH94212@kib.kiev.ua> In-Reply-To: <2A592C68-C6B3-4BAA-975C-02D325292C02@lists.zabbadoz.net> References: <201802201052.w1KAq7jQ057924@repo.freebsd.org> <2A592C68-C6B3-4BAA-975C-02D325292C02@lists.zabbadoz.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Feb 20, 2018 at 10:58:33AM +0000, Bjoern A. Zeeb wrote: > On 20 Feb 2018, at 10:52, Mateusz Guzik wrote: > > > Author: mjg > > Date: Tue Feb 20 10:52:07 2018 > > New Revision: 329639 > > URL: https://svnweb.freebsd.org/changeset/base/329639 > > > > Log: > > Make killpg1 perform process validity checks without proc lock held. > > I appreciate all these locking improvements! > > I would feel a lot more easy about them if the commit message would also > detail why these changes are possible (e.g. only read-only variables > accessed, or variables only ever accessed thread local, ..) and not just > what the change is (which the diff also tells). Removing PRS_NEW is certainly not safe. > > Also, are there people reviewing all these changes? >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180220114241.GH94212>