Date: Wed, 1 May 2024 18:08:05 +0100 From: Jessica Clarke <jrtc27@freebsd.org> To: "George V. Neville-Neil" <gnn@FreeBSD.org> Cc: "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org> Subject: Re: git: e60ca52b72e5 - main - Out of tree modules should be built with DTrace by default. Message-ID: <909C5B39-B3C0-4111-BE59-4F9B4576C4C8@freebsd.org> In-Reply-To: <202405011701.441H17Wf008095@gitrepo.freebsd.org> References: <202405011701.441H17Wf008095@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 1 May 2024, at 18:01, George V. Neville-Neil <gnn@FreeBSD.org> wrote: > > The branch main has been updated by gnn: > > URL: https://cgit.FreeBSD.org/src/commit/?id=e60ca52b72e518f8394615bdad9cd9c85764caa2 > > commit e60ca52b72e518f8394615bdad9cd9c85764caa2 > Author: George V. Neville-Neil <gnn@FreeBSD.org> > AuthorDate: 2024-05-01 17:00:52 +0000 > Commit: George V. Neville-Neil <gnn@FreeBSD.org> > CommitDate: 2024-05-01 17:00:52 +0000 > > Out of tree modules should be built with DTrace by default. > --- > share/examples/modules/Makefile | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/share/examples/modules/Makefile b/share/examples/modules/Makefile > index 0f0a2fb01e8a..bc7f6f6a57ac 100644 > --- a/share/examples/modules/Makefile > +++ b/share/examples/modules/Makefile > @@ -4,3 +4,5 @@ KMOD= skel > SRCS= skel.c > > .include <bsd.kmod.mk> > + > +CFLAGS:= ${CFLAGS:N -DKDTRACE_HOOKS} I believe this is a no-op in practice, and definitely doesn’t do what you want? :N is "select all words that don’t match the given pattern", so this expands to CFLAGS with any instances of " -DKDTRACE_HOOKS" removed. But that’s a no-op, because the space won’t be present in the word itself unless you start quoting things, and it then wouldn’t be a valid compiler flag. Jess
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?909C5B39-B3C0-4111-BE59-4F9B4576C4C8>