Skip site navigation (1)Skip section navigation (2)
Date:      03 Feb 2002 00:28:40 +0100
From:      Dag-Erling Smorgrav <des@ofug.org>
To:        Bruce Evans <bde@zeta.org.au>
Cc:        "M. Warner Losh" <imp@village.org>, <drosih@rpi.edu>, <deatley@apple.com>, <arch@FreeBSD.ORG>
Subject:   Re: __P macro question
Message-ID:  <xzp7kpvh39z.fsf@flood.ping.uio.no>
In-Reply-To: <20020131231008.P4085-100000@gamplex.bde.org>
References:  <20020131231008.P4085-100000@gamplex.bde.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Bruce Evans <bde@zeta.org.au> writes:
> When removing __P(()), don't do it like login/login.c rev.1.80:
> - mix the removal with nontrivial rewriting of the code to make it harder
>   for auditors to see the critical changes.  Change all the function
>   headers too, but don't de-verbosify the code by removing the prototypes
>   made redundant by this.
> - be sure to unsort the prototypes and add excessive indentation to them.
>   Using a low quality script to regenerate all the prototypes is a good
>   way to do this.
> ;-)

STFU, Bruce.  I can understand that you're bitter about losing the
__P() argument, but this kind of sniping is beneath even you.

Since you're so eager to deal out advice, allow me to present you with
a piece of my own: stop patronizing your fellow committers.  People
might be more inclined to listen to you if you spent more time mailing
out patches and less time lecturing.  You're getting more and more
like Terry every day.

DES
-- 
Dag-Erling Smorgrav - des@ofug.org

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-arch" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?xzp7kpvh39z.fsf>