Date: Tue, 5 Jan 2021 23:11:00 +0000 From: Brooks Davis <brooks@freebsd.org> To: Alan Somers <asomers@freebsd.org> Cc: Jessica Clarke <jrtc27@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@freebsd.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@freebsd.org> Subject: Re: git: 022ca2fc7fe0 - main - Add aio_writev and aio_readv Message-ID: <20210105231100.GD94898@spindle.one-eyed-alien.net> In-Reply-To: <CAOtMX2jqmYo%2Bzu8Q_EFiKpFOZ9ygRMpVB-bp2D1OYy90J1s-gA@mail.gmail.com> References: <202101030259.1032x5hV006606@gitrepo.freebsd.org> <B37BE19B-1AB7-4B6A-BB32-539B3C9EDB17@freebsd.org> <CAOtMX2jqmYo%2Bzu8Q_EFiKpFOZ9ygRMpVB-bp2D1OYy90J1s-gA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--XWOWbaMNXpFDWE00
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Sat, Jan 02, 2021 at 10:09:04PM -0700, Alan Somers wrote:
> On Sat, Jan 2, 2021 at 9:39 PM Jessica Clarke <jrtc27@freebsd.org> wrote:
>=20
> > On 3 Jan 2021, at 02:59, Alan Somers <asomers@FreeBSD.org> wrote:
> > > diff --git a/sys/kern/syscalls.master b/sys/kern/syscalls.master
> > > index b7ea5e939635..aaa0a1277461 100644
> > > --- a/sys/kern/syscalls.master
> > > +++ b/sys/kern/syscalls.master
> > > @@ -1477,7 +1477,17 @@
> > > _In_opt_ struct sigevent *sig
> > > );
> > > }
> > > -258-271 AUE_NULL UNIMPL nosys
> > > +258 AUE_AIO_WRITEV STD {
> > > + int aio_writev(
> > > + _Inout_ struct aiocb *aiocbp
> > > + );
> > > + }
> > > +259 AUE_AIO_READV STD {
> > > + int aio_readv(
> > > + _Inout_ struct aiocb *aiocbp
> > > + );
> > > + }
> > > +260-271 AUE_NULL UNIMPL nosys
> > > 272 AUE_O_GETDENTS COMPAT11 {
> > > int getdents(
> > > int fd,
> >
> > Should these not be added to the end?
> >
> > Jess
> >
>=20
> Should they be? I'm not aware of any requirement to add new syscalls to
> the end. I put them here so they would be next to the other AIO syscalls.
Yes. I'm sorry I missed this in the review. It's vastly easier to audit
these files and address conflicts if they are append-only. We're also
using these syscall numbers internally specifically to avoid conflicts
with new syscalls. Please move them to the end.
I do see that we only provide extremely outdated advice in the comments
of syscalls.master. I'll take a look at improving this and the wiki
page.
Thanks,
Brooks
--XWOWbaMNXpFDWE00
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQEcBAEBAgAGBQJf9PIEAAoJEKzQXbSebgfA/eUH/2Bi73K4kSotDeSO7wbxxeIp
glg+uiB2fXFeSUH1IGwT6wcR1NgDSgaIOMw9N85e6zpoCVyaU+wwJD/I8i/sSWlS
9ZLhawDObcDR1CpDcoD+8AJ70wnbFQZx90RUXvbDxiUThHm2XoUiJPoRGx3LRFhd
LiEWsWqGgcMPSsqB4tMBtgK3p2E/6SKXjkt+bppHraTp3Z8Bo88+lhdjEzYhB2AT
FzgkC1RZQt+6MjwZmYUmMW1B7rLU2Za6nO0x2wWHhgfkqJI31cvNG+knAL76fA0j
3vFwxfU1+K4VFD58CmQhYZOnTPbrz756ivnzZF+u5IkhKl/Z7W3smozjE1aoQ/c=
=Xoi+
-----END PGP SIGNATURE-----
--XWOWbaMNXpFDWE00--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20210105231100.GD94898>